Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar: Wrap link item text #2086

Conversation

ryan-henness-trimble
Copy link
Contributor

Description

Wrap the Navbar's link item text so that it doesn't overflow the width of the menu

References #2085

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested manually

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link

netlify bot commented Jan 29, 2024

Deploy Preview for moduswebcomponents ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1216e87
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/65b7f312b199c20008a08aa5
😎 Deploy Preview https://deploy-preview-2086--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 27 (no change from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@enowak1031
Copy link

  • Waiting on input from MoAB and TID. So far the preference is to truncate instead.

@cjwinsor cjwinsor added the blocked blocked label Jan 31, 2024
@cjwinsor
Copy link
Contributor

I marked this blocked while we wait for a design proposal that is being worked on.

@cjwinsor cjwinsor merged commit d3a1513 into trimble-oss:main Jun 4, 2024
8 checks passed
@cjwinsor
Copy link
Contributor

cjwinsor commented Jun 4, 2024

This was approved by modus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants