-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add modus-textarea-input
component.
#2336
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for moduswebcomponents ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
stencil-workspace/src/components/modus-textarea-input/modus-textarea-input.spec.tsx
Outdated
Show resolved
Hide resolved
stencil-workspace/src/components/modus-textarea-input/modus-textarea-input.scss
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
23a9ac4
to
acf1c97
Compare
This comment was marked as resolved.
This comment was marked as resolved.
I have added some new properties to make this more consistent with |
@austinoneil @cjwinsor - I think it'd be good to get the conflicts resolved (sorry for letting this PR be open for so long!) and then reviewed and merged in time for the next release later this week. I know of a Trimble team interested in using this component. |
I've been tied up, so I haven't properly reviewed. Though I did notice weird behavior with using the inputs resize handle. We could probably restrict that to only vertical, but it still gets a little crazy as you resize as the input resizing doesn't also resize the wrapping styling components. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…onents/src/lib/stencil-generated/angular-component-lib/utils.ts
I have removed most of the erroneously added files. Some were gitignored in #2340 so I think that might be preventing me from running a |
Description
Add
modus-textarea-input
component.References #2327
Type of change
How Has This Been Tested?
Added the following HTML to index.html:
Checklist