Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modus-textarea-input component. #2336

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

austinoneil
Copy link
Contributor

@austinoneil austinoneil commented Mar 23, 2024

Description

Add modus-textarea-input component.

References #2327

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Added the following HTML to index.html:

<modus-textarea-input label="standard input"></modus-textarea-input>
<modus-textarea-input label="standard input with 3 rows" rows="3"></modus-textarea-input>

image

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link

netlify bot commented Mar 23, 2024

Deploy Preview for moduswebcomponents ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7745340
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/66461037cbbed70007659daf
😎 Deploy Preview https://deploy-preview-2336--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 25 (no change from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@austinoneil austinoneil mentioned this pull request Mar 23, 2024
13 tasks
@coliff

This comment was marked as resolved.

@austinoneil

This comment was marked as outdated.

@coliff

This comment was marked as resolved.

@austinoneil

This comment was marked as resolved.

@coliff coliff requested a review from cjwinsor March 26, 2024 14:47
@austinoneil

This comment was marked as resolved.

@austinoneil
Copy link
Contributor Author

I have added some new properties to make this more consistent with input.

@coliff
Copy link
Member

coliff commented Apr 22, 2024

@austinoneil @cjwinsor - I think it'd be good to get the conflicts resolved (sorry for letting this PR be open for so long!) and then reviewed and merged in time for the next release later this week. I know of a Trimble team interested in using this component.

@cjwinsor
Copy link
Contributor

@austinoneil @cjwinsor - I think it'd be good to get the conflicts resolved (sorry for letting this PR be open for so long!) and then reviewed and merged in time for the next release later this week. I know of a Trimble team interested in using this component.

I've been tied up, so I haven't properly reviewed. Though I did notice weird behavior with using the inputs resize handle. We could probably restrict that to only vertical, but it still gets a little crazy as you resize as the input resizing doesn't also resize the wrapping styling components.

@coliff

This comment was marked as resolved.

@coliff

This comment was marked as resolved.

@austinoneil

This comment was marked as resolved.

@coliff

This comment was marked as resolved.

@austinoneil

This comment was marked as resolved.

@austinoneil
Copy link
Contributor Author

I have removed most of the erroneously added files. Some were gitignored in #2340 so I think that might be preventing me from running a git checkout main <path> and updating them. I think owners for the repo might be able to remove them on the web UI, but I am not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants