Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Dropzone: Make message customizable #2388

Merged
merged 6 commits into from
May 30, 2024

Conversation

austinoneil
Copy link
Contributor

@austinoneil austinoneil commented Apr 1, 2024

Description

Make filezone messages customizable. Also fixed a minor issue with a "null" class rendering.

Resolves #1741

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Added unit tests.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link

netlify bot commented Apr 1, 2024

Deploy Preview for moduswebcomponents ready!

Name Link
🔨 Latest commit 9af6e48
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/6658966a0e6452000831b694
😎 Deploy Preview https://deploy-preview-2388--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 26 (🟢 up 2 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coliff coliff self-requested a review April 1, 2024 23:12
@coliff coliff changed the title Filezone:Make messages customizable. File Dropzone: Make message customizable Apr 10, 2024
coliff
coliff previously approved these changes Apr 10, 2024
cjwinsor
cjwinsor previously approved these changes May 30, 2024
@cjwinsor cjwinsor dismissed stale reviews from coliff and themself via 9af6e48 May 30, 2024 15:08
@cjwinsor cjwinsor merged commit d29aba7 into trimble-oss:main May 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modus File Upload Dropzone - Add support for customizing the messages
3 participants