Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: Update Edit mode #2443

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

ElishaSamPeterPrabhu
Copy link
Collaborator

@ElishaSamPeterPrabhu ElishaSamPeterPrabhu commented Apr 16, 2024

Description

  • Added tabbing in edit mode
  • Escape will remove focus

References
#2437

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for moduswebcomponents ready!

Name Link
🔨 Latest commit a1d2d47
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/66668d2493afea000805169e
😎 Deploy Preview https://deploy-preview-2443--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 26 (🟢 up 2 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ElishaSamPeterPrabhu ElishaSamPeterPrabhu changed the title Update table cell Table : Update Edit mode Apr 16, 2024
@cjwinsor
Copy link
Contributor

@ElishaSamPeterPrabhu Testing using the storybook required me to tab twice to edit the cell. So

  • I start editing one cell
  • Press Tab
  • Press Tab
  • Now I can edit the next cell

Can we remove the extra Tab?

@ElishaSamPeterPrabhu
Copy link
Collaborator Author

@ElishaSamPeterPrabhu Testing using the storybook required me to tab twice to edit the cell. So

  • I start editing one cell
  • Press Tab
  • Press Tab
  • Now I can edit the next cell

Can we remove the extra Tab?

Since there are two "states" for each cell initially when it appears in table cell the edit mode is not enabled , but when clicking enter or tab on that cell enables it and replaces the previous state with the respective editable mode.
We can remove double tabs by enabling edit mode for all editable cells the moment tab is clicked hence it goes to respective editable mode for all cells having it and then while tabbing we can edit them with single tabs

@coliff coliff changed the title Table : Update Edit mode Table: Update Edit mode Apr 26, 2024
@coliff coliff requested a review from cjwinsor April 26, 2024 11:34
coliff

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants