Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: Manual Pagination currentPagesize not working on initial load fix #2524

Conversation

prashanthr6383
Copy link
Collaborator

@prashanthr6383 prashanthr6383 commented May 14, 2024

Description

  • Fixed the manual pagination - currentpageSize prop not working on initial load
  • Page view select will be empty on user defined page size.

References
Fix #2395

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link

netlify bot commented May 14, 2024

Deploy Preview for moduswebcomponents ready!

Name Link
🔨 Latest commit eb92309
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/66430651aeeae70008dbcdf4
😎 Deploy Preview https://deploy-preview-2524--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 22 (🔴 down 4 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@prashanthr6383 prashanthr6383 added bug Something is wrong and needs to be addressed modus-table Modus Table component development labels May 14, 2024
@cjwinsor cjwinsor changed the title Table - Manual Pagination currentPagesize not working on initial load fix Table: Manual Pagination currentPagesize not working on initial load fix May 17, 2024
@cjwinsor cjwinsor merged commit 5f92464 into main May 17, 2024
9 checks passed
@cjwinsor cjwinsor deleted the 2395---Table--Manual-Pagination-currentPageSize-not-honored-on-initial-load branch May 17, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong and needs to be addressed modus-table Modus Table component development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table: Manual Pagination currentPageSize not honored on initial load
2 participants