Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ldap support for password auth #104

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

derbeneviv
Copy link

Hi all!
Thanks for a great chart, but it lacks some functionality.

In our environment we needed to use a ldap auth, so i've added this to a chart, and am hoping this can be merged to upstream

Copy link

cla-bot bot commented Nov 3, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: DERBENEV Ivan V.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Nov 3, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: DERBENEV Ivan V.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Nov 3, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: DERBENEV Ivan V.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Nov 3, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: DERBENEV Ivan V.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

add ldap
Copy link

cla-bot bot commented Nov 3, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@nineinchnick
Copy link
Member

@derbeneviv are you still interested in working on this? We should have tests for this, which would require running an LDAP server. Maybe we can discuss how to best do this.

@alexagc
Copy link

alexagc commented May 22, 2024

Hi @nineinchnick we are interested in add this support, maybe i can continue with this work but as far i see seen promising and dont need much changes

@nineinchnick
Copy link
Member

@alexagc can you always open up a second PR with these changes. The implementation looks fine, but it definitely needs tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants