Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catalogsConfigmapOverride #92

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

soft-titus
Copy link

This to provide ability to use our own configmap for the catalogs instead of adding the catalogs inline in the values.yaml, for example :

catalogsConfigmapOverride: my-trino-catalog-configmap

Thanks.

@cla-bot
Copy link

cla-bot bot commented Jul 22, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@nineinchnick
Copy link
Member

@soft-titus can you rebase, and configure it in https://github.com/trinodb/charts/blob/main/test-values.yaml, so we can see if it works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants