Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add constructor of RenameColumn without NodeLocation #20909

Closed
wants to merge 1 commit into from
Closed

Add constructor of RenameColumn without NodeLocation #20909

wants to merge 1 commit into from

Conversation

takezoe
Copy link
Member

@takezoe takezoe commented Mar 2, 2024 •
edited

Description

Add constructor of RenameColumn which doesn't take NodeLocation as other tree nodes.

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Mar 2, 2024
martint
martint requested changes Mar 2, 2024
View reviewed changes
Copy link
Member

@martint martint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All AST nodes should have a location. The fact that some of then don’t is due to legacy reasons, but we’re in the process of changing that once the AST is completely split from the usage as IR

@takezoe
Copy link
Member Author

takezoe commented Mar 2, 2024

I see. Thank you for explanation.

@takezoe takezoe closed this Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martint martint martint requested changes

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@takezoe @martint