Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CI green by changing MSRV policy to "last three stable versions" #462

Merged
merged 2 commits into from Jan 12, 2023

Conversation

Enselic
Copy link
Collaborator

@Enselic Enselic commented Jan 5, 2023

CI has been red for a while now, caused by us not bumping MSRV.

It doesn't make sense for us to have a generous MSRV policy if we don't maintain it. So make our MSRV policy less generous by changing it to "last three stable versions". This is also what time (which we frequently have MSRV problems with) will start using, see time-rs/time#535. Clap has an even less generous one: https://docs.rs/clap/latest/clap/

We will support the last two minor Rust releases

If someone is interested in reading more about MSRV policies, I recommend to read these discussions:

The reality is that if someone needs a more generous MSRV policy, then that someone needs to help us maintain it. I'm afraid it's not going to be me. If someone insists on using an old version of Rust, I do not think it is unreasonable for us to insist on that someone to also use an old version of syntect.

Also fix a lint.

@trishume trishume merged commit 4081d0e into trishume:master Jan 12, 2023
@Enselic Enselic deleted the make-ci-green branch December 28, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants