Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add th attribute data-sort-reverse #184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zevero
Copy link

@zevero zevero commented Mar 9, 2020

I needed to have different sort order for columns
Honoring the global option descending:true and avoiding any asc, desc logic I just added the attribute data-sort-reverse.

@tristen
Copy link
Owner

tristen commented Mar 10, 2020

👋 @zevero thanks for the PR. I'm curious why aria-sort isn't enough and why a data-sort-reverse attribute is necessary.

@zevero
Copy link
Author

zevero commented Mar 10, 2020

Thanks for your quick response @tristen !
I tried aria-sort on my column and yes it seemed to work initially. But when sorting another column in between aria-sort ends up beeing cleared and from now on that column will be sorted contrary as expected.
So thats why I introduced an everlasting data-sort-reverse ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants