Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for prettier 3 #240

Closed
Ericlm opened this issue Jul 6, 2023 · 5 comments
Closed

Support for prettier 3 #240

Ericlm opened this issue Jul 6, 2023 · 5 comments
Labels
feature request A new feature request

Comments

@Ericlm
Copy link

Ericlm commented Jul 6, 2023

Is your feature request related to a problem?
Prettier has just been updated to version 3.0.0 (see the changelog) ; however, this package only supports prettier up to 2.x.y.

Describe the solution you'd like
It would be great if this plugin could work with versions > prettier 3.0.0

Describe alternatives you've considered
So far, I stay on version 2.8.8

@basselworkforce
Copy link
Contributor

PR submitted: #239

@basselworkforce
Copy link
Contributor

basselworkforce commented Jul 21, 2023

The PR is now merged as v4.2.0, please note during my testing I found that I now had to add the plugin to the config with npm (when I never had to before) as per:

module.exports = {
    ...
    "plugins": ["@trivago/prettier-plugin-sort-imports"]
}

https://github.com/trivago/prettier-plugin-sort-imports#usage

@gentle-noah
Copy link

@basselworkforce - which config file specifically?

@clintonb
Copy link

prettierrc: https://prettier.io/docs/en/plugins.html

@kellengreen
Copy link

Confirmed working, thanks everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A new feature request
Projects
None yet
Development

No branches or pull requests

5 participants