Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump babel to support satisfies keyword #196

Merged
merged 5 commits into from Feb 23, 2023

Conversation

leomotors
Copy link
Contributor

Currently, this plugin does not support TS 4.9 satisfies keyword and will throw parsing errors because Babel's version is outdated.

Babel added support for satisfies version in 7.20 https://babeljs.io/blog/2022/10/27/7.20.0

This PR bumped the dependencies

Please consider this PR quick as it slightly blocks many developers🙏

@leomotors
Copy link
Contributor Author

Unit test failing 😱

Seems like new version of babel parser loves to add new lines

@leomotors
Copy link
Contributor Author

I have reverted all babel's dependencies except @babel/parser

This should do the trick and solve unit test failure.

I also added a snapshot test for satisfies

@ratierd
Copy link
Contributor

ratierd commented Jan 4, 2023

@ayusharma @byara This looks good to go.
Would it be possible to create a release for that specific issue (supporting the satisfies keyword in typescript) ?

@enisdenjo
Copy link

Any progress here? I'd love to help out if I can expedite the process! 😄

enisdenjo added a commit to kamilkisiela/graphql-hive that referenced this pull request Jan 16, 2023
enisdenjo added a commit to kamilkisiela/graphql-hive that referenced this pull request Jan 17, 2023
dimaMachina pushed a commit to kamilkisiela/graphql-hive that referenced this pull request Jan 18, 2023
@ratierd
Copy link
Contributor

ratierd commented Jan 23, 2023

@ayusharma @byara This issue has been hanging for a while.

There is a workaround (kamilkisiela/graphql-hive@bcafedb) but we would still need to release this in a new version for everyone to update smoothly.

I don't know the proper process to do that but maybe I could help with that ?
@enisdenjo seems to be interested as well.

@Pettor
Copy link

Pettor commented Feb 10, 2023

Any progress on merging and releasing this?

@sandervspl
Copy link

sandervspl commented Feb 10, 2023

You're better off forking this project or using existing forks.

To the maintainers: please don't release and open source anything if you don't have the people and/or the time to maintain it.

"@babel/traverse": "7.17.3",
"@babel/types": "7.17.0",
"javascript-natural-sort": "0.7.1",
"lodash": "4.17.21"
"lodash": "^4.17.21"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not use the fixed version for the deps like7.20.5 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since lodash is the dependency of this package. Users who install this package will install lodash too, so in my opinion it is best to be as flexible as possible by using ^ or ~

@byara byara merged commit 78b776f into trivago:master Feb 23, 2023
@ayusharma
Copy link
Collaborator

Released in v4.1.0. I appreciate your patience. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants