New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump babel to support satisfies keyword #196
Conversation
Unit test failing 😱 Seems like new version of babel parser loves to add new lines |
I have reverted all babel's dependencies except This should do the trick and solve unit test failure. I also added a snapshot test for |
@ayusharma @byara This looks good to go. |
Any progress here? I'd love to help out if I can expedite the process! 😄 |
@ayusharma @byara This issue has been hanging for a while. There is a workaround (kamilkisiela/graphql-hive@bcafedb) but we would still need to release this in a new version for everyone to update smoothly. I don't know the proper process to do that but maybe I could help with that ? |
Any progress on merging and releasing this? |
You're better off forking this project or using existing forks. To the maintainers: please don't release and open source anything if you don't have the people and/or the time to maintain it. |
"@babel/traverse": "7.17.3", | ||
"@babel/types": "7.17.0", | ||
"javascript-natural-sort": "0.7.1", | ||
"lodash": "4.17.21" | ||
"lodash": "^4.17.21" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we not use the fixed version for the deps like7.20.5
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since lodash
is the dependency of this package. Users who install this package will install lodash
too, so in my opinion it is best to be as flexible as possible by using ^
or ~
…rts into chore/deps
Released in v4.1.0. I appreciate your patience. ❤️ |
Currently, this plugin does not support TS 4.9
satisfies
keyword and will throw parsing errors because Babel's version is outdated.Babel added support for
satisfies
version in 7.20 https://babeljs.io/blog/2022/10/27/7.20.0This PR bumped the dependencies
Please consider this PR quick as it slightly blocks many developers🙏