Move @babel/core to devDependencies #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is actually a blocker for this plugin supporting TypeScript 4.9 as the babel deps are so out of date that it causes eslint parsing to fail. |
|
Related issue: prettier/prettier#13951 |
leomotors
approved these changes
Feb 18, 2023
byara
approved these changes
Feb 23, 2023
|
Released in v4.1.0. I appreciate your patience. ❤️ |
|
Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I see,
@babel/coreis only used for testing in this repository.I think it would be better to move it to
devDependenciesbecause this plugin users can reduce npm dependencies in their lock files;@babel/corehas many dependencies, so I will have to bump many dependencies in myyarn.lockif they have updates.I just ran
yarn remove @babel/coreandyarn add --dev @babel/core.What do you think?