fix: check for pane focus before removing it.

Fixes electron#16883. This bug seems to have been introduced in the electron#15302's menu a11y refactor and is new in 5-0-x.
trop-bot · Mar 4, 2019 · 409d4c8 · 409d4c8
1 parent 51c5882
commit 409d4c8
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/atom/browser/ui/views/menu_bar.cc b/atom/browser/ui/views/menu_bar.cc
@@ -118,7 +118,9 @@ bool MenuBar::GetMenuButtonFromScreenPoint(const gfx::Point& screenPoint,
 }
 
 void MenuBar::OnBeforeExecuteCommand() {
-  RemovePaneFocus();
+  if (GetPaneFocusTraversable() != nullptr) {
+    RemovePaneFocus();
+  }
   window_->RestoreFocus();
 }