Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Print Items #330

Merged
merged 40 commits into from Jul 25, 2019
Merged

Feature: Print Items #330

merged 40 commits into from Jul 25, 2019

Conversation

inukshuk
Copy link
Member

@inukshuk inukshuk commented Feb 19, 2019 •
edited

  • Add print preview window
  • Print app command
  • Send selected items to print preview
  • Render items
  • Render photos
  • Render notes
  • Render metadata
  • Show print dialog when ready (all images have been loaded!)
  • Move preview window off-screen if necessary
  • Close after printing (or cancel)
  • Wait for fix: callback values for printing cancellation and success electron/electron#17400
  • Add printing preferences?
  • Styles
  • Open Issues for remaining print options
  • Translate printing prefs

Closes #329

@inukshuk inukshuk force-pushed the feature/print branch 3 times, most recently from c3cfc5b to 6445a77 Compare March 21, 2019 15:57
inukshuk and others added 18 commits July 20, 2019 13:35
@inukshuk
Localize printed metadata headers
5387750
@inukshuk
Print item metadata
5484fb6 
Print item and photo info
@inukshuk
Print photo notes
451277c
@inukshuk
Add print preferences
ba85588 
Added preferences for mode, metadata/notes inclusion,
and whether or not to allow overflow.
@inukshuk
Add print settings to preferences
d26b517
@inukshuk
Actually print again
451a2c5
@inukshuk
Show print dialog after all photos have loaded
2188034
@flachware
Add overflow class, rename .page to .container.
350d52c
@inukshuk
Conditionally set overflow and metadata classes
d85dd70
@inukshuk
Remove cover and popup root from print view
2b986db
@flachware
Add styles for overflow layout. Ensure min size of photos in default …
6ecc7b5 
…layout.
@flachware
Fix note font-size in overflow layout.
7356538
@flachware
Tweak notes layout and headings.
8377e32
@flachware
Stretch empty note paragraphs in print.
1ec6cd9
@flachware
Tweak page margin and spacing.
af2dc62
@flachware
Fix scaffolding.
5b85116
@flachware
Style notes.
762acec
@flachware
Tweak vertical spacing.
19c24ea
@inukshuk inukshuk marked this pull request as ready for review July 25, 2019 17:55
@inukshuk inukshuk merged commit 90de31f into master Jul 25, 2019
@inukshuk inukshuk deleted the feature/print branch July 25, 2019 17:56
@Emic37
Copy link

Emic37 commented Jul 29, 2019

I translated in French the printing prefs. ;-) I can't wait to try this new feature.

@inukshuk
Copy link
Member Author

inukshuk commented Aug 3, 2019

Thanks! I just pushed the 1.5.3 release which enables printing. We don't support all modes we've planned yet, but in combination with the print dialog you should already have some flexibility.

If I remember your original use case correctly, I think that should already be possible, but let us know how it goes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@inukshuk inukshuk

@flachware flachware

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to print selected items
3 participants
@inukshuk @Emic37 @flachware