Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose getQueryKey on mutation procedures #3528

Closed
wants to merge 3 commits into from

Conversation

hdwatts
Copy link

@hdwatts hdwatts commented Dec 31, 2022

🎯 Changes

In #3302 getQueryKey was exposed for all query procedures. I was hoping to be able to use the feature for setMutationDefaults - however the method was not exposed on mutation queries.

Happy New Year!

✅ Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

@vercel
Copy link

vercel bot commented Dec 31, 2022

@hdwatts is attempting to deploy a commit to the trpc Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Dec 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
www ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 31, 2022 at 8:33PM (UTC)

Copy link
Member

@KATT KATT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't do anything as we currently (don't seem to?) use mutationKey - see #3534.

Feel free to include that change int the PR and re-request review :)

@KATT
Copy link
Member

KATT commented Jan 31, 2023

superseded by #3631

@KATT KATT closed this Jan 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants