chore: use vitest expect-type only #4868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Oh, it looks like vitest exports their forked |
|
Updated to remove the expect-type dependency completely for now. If trpc is using vitest it should just use the re-exported version from there. |
KATT
previously approved these changes
Oct 6, 2023
|
thanks for this :) |
# Conflicts: # packages/client/package.json # packages/server/package.json # pnpm-lock.yaml
KATT
previously approved these changes
Oct 6, 2023
KATT
previously approved these changes
Oct 6, 2023
juliusmarminge
approved these changes
Oct 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
🎯 Changes
Replace copy-pasted expect-type from mmkal/expect-type#16 with the prerelease version published to npm.
Creating as a draft initially so I can make sure this doesn't regress anything. I ran
pnpm test-ciwith and without this change a bunch of times and the timing was pretty much the same, and it passes.Note: I don't actually see how
inferenceUtils.tsis ever referenced but I'm guessing there's some tsconfig setup making its exports available globally. So I just replaced its contents withexport * from 'expect-type'.CC @KATT and @neo773 who I think copy-pasted it originally in #3271? Anything I should check before declaring #mmkal/expect-type#16 ready for release? I want to make sure this repo and vitest are both happy with it and can stop maintaining forks.
✅ Checklist