Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove more internal exports #5101

Closed
wants to merge 35 commits into from
Closed

fix: remove more internal exports #5101

wants to merge 35 commits into from

Conversation

KATT
Copy link
Member

@KATT KATT commented Nov 24, 2023

Closes #

🎯 Changes

Remove a bunch of external imports

ref #3496:

[ ] Look through @internal-marked types/fns and see if we can avoid exposing them in the bundle altogether

  • Overall, we should try to get rid of export * from X and have index files that only export exactly what we want
  • Once we've done this, we need to look at third party libraries using trpc and make sure that they have a migration path - maybe we start exporting some stuff specifically for plugins

✅ Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

Copy link

vercel bot commented Nov 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-prisma-starter ❌ Failed (Inspect) Dec 23, 2023 10:48pm
og-image ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2023 10:48pm
trpc-next-app-dir ❌ Failed (Inspect) Dec 23, 2023 10:48pm
www ❌ Failed (Inspect) Dec 23, 2023 10:48pm

Copy link

github-actions bot commented Nov 24, 2023

Diagnostics Comparison

Numbers

Metric PR next
Files 750 751 (🔽🟢 -1)
Lines of Library 40,241 40,241 (➖ 0)
Lines of Definitions 118,672 118,674 (🔽🟢 -2)
Lines of TypeScript 4,867 4,867 (➖ 0)
Lines of JavaScript 0 0 (➖ 0)
Lines of JSON 0 0 (➖ 0)
Lines of Other 0 0 (➖ 0)
Identifiers 174,321 174,296 (🔺 25)
Symbols 108,780 108,767 (🔺 13)
Types 89 89 (➖ 0)
Instantiations 0 0 (➖ 0)
Memory used 173,983 168,462 (🔺 5,521)
Assignability cache size 0 0 (➖ 0)
Identity cache size 0 0 (➖ 0)
Subtype cache size 0 0 (➖ 0)
Strict subtype cache size 0 0 (➖ 0)

Timings and averages

Metric PR next
max (s) 4.994 4.903 (🔺 0.09)
min (s) 4.863 4.829 (🔺 0.03)
avg (s) 4.932 4.866 (🔺 0.07)
median (s) 4.933 4.864 (🔺 0.07)
length 21 21 (➖ 0)
unstable timings

Unstable

Timings are not reliable in here

Metric PR next
I/O Read time 0.04 0.04 (➖ 0)
Parse time 0.74 0.74 (➖ 0)
ResolveTypeReference time 0.03 0.03 (➖ 0)
ResolveModule time 0.13 0.12 (🔺 0.01)
ResolveLibrary time 0.02 0.02 (➖ 0)
Program time 1.09 1.07 (🔺 0.02)
Bind time 0.43 0.43 (➖ 0)
Total time 1.52 1.51 (🔺 0.01)

# Conflicts:
#	packages/client/src/links/wsLink.ts
# Conflicts:
#	.wip/changes.md
#	packages/client/src/TRPCClientError.ts
#	packages/react-query/src/shared/hooks/createHooksInternal.tsx
#	packages/tests/server/___testHelpers.ts
@KATT
Copy link
Member Author

KATT commented Dec 23, 2023

I think #5101 is a better approach - closing, might re-open later

@KATT KATT closed this Dec 23, 2023
@KATT KATT deleted the housekee-again branch December 23, 2023 23:01
Copy link

This pull request has been locked because we are very unlikely to see comments on closed issues. If you think, this PR is still necessary, create a new one with the same branch. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants