Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump Vite and Vitest #5165

Merged
merged 25 commits into from
Feb 8, 2024
Merged

chore: bump Vite and Vitest #5165

merged 25 commits into from
Feb 8, 2024

Conversation

juliusmarminge
Copy link
Member

Closes #

🎯 Changes

What changes are made in this PR? Is it a feature or a bug fix?

βœ… Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

@juliusmarminge juliusmarminge requested a review from a team as a code owner December 15, 2023 14:16
@juliusmarminge juliusmarminge changed the title chore: bump dep and update snaps chore: bump Vite and Vitest Dec 15, 2023
Copy link

vercel bot commented Dec 15, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
next-prisma-starter βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Feb 8, 2024 9:43am
og-image βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Feb 8, 2024 9:43am
trpc-next-app-dir βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Feb 8, 2024 9:43am
www βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Feb 8, 2024 9:43am

KATT
KATT previously approved these changes Dec 15, 2023
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vitest just doesn't wanna work with the arraybuffers here...

good to just skip these tests or should we drop this PR? @KATT

@juliusmarminge juliusmarminge merged commit 6d0bde8 into next Feb 8, 2024
37 checks passed
@juliusmarminge juliusmarminge deleted the vite-vitest branch February 8, 2024 12:19
Copy link

github-actions bot commented Feb 9, 2024

This pull request has been locked because we are very unlikely to see comments on closed issues. If you think, this PR is still necessary, create a new one with the same branch. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants