ignore #5681
Closed
ignore #5681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…26-resolveResponse
3 tasks
KATT
commented
Apr 28, 2024
Comment on lines
+12
to
+43
| let size = 0; | ||
| const maxBodySize = opts.maxBodySize; | ||
|
|
||
| let controller: ReadableStreamDefaultController<Value> = | ||
| null as unknown as ReadableStreamDefaultController<Value>; | ||
| const stream = new ReadableStream<Value>({ | ||
| start(c) { | ||
| controller = c; | ||
| }, | ||
| async pull(c) { | ||
| const chunk: Value = req.read(); | ||
|
|
||
| if (chunk) { | ||
| size += chunk.length; | ||
| } | ||
| if (maxBodySize !== null && size > maxBodySize) { | ||
| controller.error( | ||
| new TRPCError({ | ||
| code: 'PAYLOAD_TOO_LARGE', | ||
| }), | ||
| ); | ||
| return; | ||
| } | ||
| if (chunk === null) { | ||
| c.close(); | ||
| return; | ||
| } | ||
| controller.enqueue(chunk); | ||
| }, | ||
| cancel() { | ||
| req.destroy(); | ||
| }, |
There was a problem hiding this comment.
Considering dropping maxBodySize in order to simplify this, it can be replaced by just using the IncomingMessage as the body (as it is a stream)
|
This pull request has been locked because we are very unlikely to see comments on closed issues. If you think, this PR is still necessary, create a new one with the same branch. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.