Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move complexity from resolveResponse #5691

Merged
merged 33 commits into from Apr 30, 2024

Conversation

KATT
Copy link
Member

@KATT KATT commented Apr 28, 2024

  • move some complexity from resolveResponse to the content type handlers
  • basically, content types does the request planning and returns the calls that are made and getters for their inputs

not sure if you prefer this @Nick-Lucas

Copy link

vercel bot commented Apr 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-prisma-starter ✅ Ready (Inspect) Visit Preview Apr 29, 2024 8:10am
og-image ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 8:10am
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 8:10am

Copy link

github-actions bot commented Apr 28, 2024

Diagnostics Comparison

Numbers

Metric PR next
Files 798 793 (🔺 5)
Lines of Library 40,640 40,640 (➖ 0)
Lines of Definitions 120,081 119,101 (🔺 980)
Lines of TypeScript 4,967 4,967 (➖ 0)
Lines of JavaScript 0 0 (➖ 0)
Lines of JSON 0 0 (➖ 0)
Lines of Other 0 0 (➖ 0)
Identifiers 175,834 175,321 (🔺 513)
Symbols 109,348 108,991 (🔺 357)
Types 89 89 (➖ 0)
Instantiations 0 0 (➖ 0)
Memory used 176,873 176,351 (🔺 522)
Assignability cache size 0 0 (➖ 0)
Identity cache size 0 0 (➖ 0)
Subtype cache size 0 0 (➖ 0)
Strict subtype cache size 0 0 (➖ 0)

Timings and averages

Metric PR next
max (s) 4.362 4.346 (🔺 0.02)
min (s) 4.362 4.346 (🔺 0.02)
avg (s) 4.362 4.346 (🔺 0.02)
median (s) 4.362 4.346 (🔺 0.02)
length 1 1 (➖ 0)
unstable timings

Unstable

Timings are not reliable in here

Metric PR next
I/O Read time 0.04 0.04 (➖ 0)
Parse time 0.71 0.71 (➖ 0)
ResolveTypeReference time 0.03 0.03 (➖ 0)
ResolveModule time 0.11 0.11 (➖ 0)
ResolveLibrary time 0.02 0.02 (➖ 0)
Program time 1.05 1.04 (🔺 0.01)
Bind time 0.42 0.41 (🔺 0.01)
Total time 1.47 1.46 (🔺 0.01)

… 04-26-resolveResponse-iii

# Conflicts:
#	packages/server/src/unstable-core-do-not-import/http/types.ts
@Lilja
Copy link
Contributor

Lilja commented Apr 29, 2024

As written in discord, but moving to github for posterity:

I tried the latest build and it does not work for me. The response time was increased to 600-700ms(from 200-300ms) and did not return any json data in the response.

11.0.0-alpha-tmp-04-26-resolveResponse-and-multi.428 breaks my fastify backend

11.0.0-alpha-tmp-04-26-resolveResponse-and-multi.427 works all fine an dandy

@KATT KATT merged commit 3d33679 into 04-26-resolveResponse-and-multi Apr 30, 2024
36 of 37 checks passed
@KATT KATT deleted the 04-26-resolveResponse-iii branch April 30, 2024 16:09
Copy link

github-actions bot commented May 1, 2024

This pull request has been locked because we are very unlikely to see comments on closed issues. If you think, this PR is still necessary, create a new one with the same branch. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants