NAS-115112 / None / zfsd: add support for hotplugging spares #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
zfsd fetches new pool configuration through ZFS_IOC_POOL_STATS but it does not get updated nvlist configuration for spare vdev since the configuration is read by spa_spares->sav_config. In this commit, updating the vdev state for spare vdev that is consumed by zfsd on spare disk hotplug. Reviewed-by: Alexander Motin <mav@FreeBSD.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ameer Hamza <ahamza@ixsystems.com> Closes #14653
If you remove an unused spare and then reinsert it, zfsd will now online it in all pools. Do not MFC without 2a58b31 (but it's ok to MFC that one without this one). Submitted by: Ameer Hamza <ahamza@ixsystems.com> (zfsd), Me (tests) MFC after: 2 weeks MFC with: 2a58b31 Sponsored by: iX Systems, Axcient Pull Request: freebsd/freebsd-src#697
ixhamza
force-pushed
the
NAS-115112-stable-13
branch
from
5dc92e1
to
960a8ce
Compare
|
On Core we are building alternative version of ZFS via ports instead of the bundled OS one. So while this PR looks OK to me, it should be merged only after we update OpenZFS ports to 2.1.10 after one released, otherwise we'll loose the kernel part. |
amotin
approved these changes
Apr 12, 2023
usaleem-ix
approved these changes
Apr 12, 2023
|
Drafting it for now to check more about the zfsd port. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you remove an unused spare and then reinsert it, zfsd will now online it in all pools.
Submitted by: Ameer Hamza ahamza@ixsystems.com (zfsd), Me (tests)
MFC after: 2 weeks
MFC with: 2a58b31
Sponsored by: iX Systems, Axcient
Pull Request: freebsd/freebsd-src#697