Use recover to catch panic in dep for old rars #801
Merged
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrav
approved these changes
Sep 16, 2022
KidiIT
reviewed
Jan 17, 2024
There was a problem hiding this comment.
Approved for the same price and the other one was for a different brand and the price was the only difference that we could get from it so we could have it delivered on the day that you guys would like to get the same thing and then you can get the exact amount you need it for your house.✔️🫶
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some old rars can cause a crash in rardecoder. Catching the panic since I can not find an example that reproduces the panic. An issue is open in rardecode to track nwaples/rardecode#30