Skip to content

Use headref and check empty commits for base #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2022
Merged

Use headref and check empty commits for base #815

merged 1 commit into from
Sep 21, 2022
+15 −15

Conversation

bill-rich
Copy link
Collaborator

@bill-rich bill-rich commented Sep 21, 2022 •
edited
Loading

headCommit was being set to the base commit, and zero-diff commits were getting skipped in baseRef check.

Fixes #666

@bill-rich
Use headref and check empty commits for base

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f59bb12
@bill-rich bill-rich requested review from a team as code owners September 21, 2022 22:45
dustin-decker
dustin-decker approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@dustin-decker dustin-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@dustin-decker
Copy link
Contributor

Does this resolve #666?

@bill-rich
Copy link
Collaborator Author

Does this resolve #666?

It does. Added that to the description.

@bill-rich bill-rich merged commit 509cf8b into main Sep 21, 2022
@bill-rich bill-rich deleted the THOG-720_fix_range_scan branch September 21, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustin-decker dustin-decker

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Github Action on pull request not behaving as expected
2 participants
@bill-rich @dustin-decker