Support and migrate to eslint@9.0.0 #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 1h 59m total CI duration on this PR
|
|
Ultimately, there are 2 existing issues warranting this change (or a similar one):
|
This was referenced Apr 15, 2024
TylerJang27
added a commit
that referenced
this pull request
Apr 15, 2024
Fixes [failures](https://github.com/trunk-io/trunk/actions/runs/8659672695/job/23746050111) and cleans up dependabot ignores for `eslint` until #735 is resolved. [Successful run](https://github.com/trunk-io/trunk/actions/runs/8693488278/job/23840365226)
Merged
TylerJang27
added a commit
that referenced
this pull request
Apr 23, 2024
Offers some temporary fixes to make `main` green and provide a migration guide until we have a long-term story for #735. Also includes a node fix with [executing `.bat` files](https://github.com/trunk-io/plugins/actions/runs/8702103641/job/23865448625) related to prebuild/prebuildify#83
TylerJang27
force-pushed
the
tyler/eslint-9
branch
3 times, most recently
from
aed6721
to
948302b
Compare
|
💊 0 quarantined ✅ 261 passed 🕐 266 new ⋅ (learn more) |
TylerJang27
force-pushed
the
tyler/eslint-9
branch
from
948302b
to
43afc2e
Compare
|
@det Plan for release since older CLI versions will naively respect LUV, AND also won't have the direct_configs update here:
The patch is only necessary for extra caution, in case someone is on a new CLI version but not a new plugins version (or on an old CLI version). |
det
approved these changes
May 30, 2024
TylerJang27
added a commit
that referenced
this pull request
May 31, 2024
This is a temporary mechanism to avoid sending new, 9.x validated versions for eslint to LUV. That way, we can make a plugins release that has the eslint9 support, and users on older CLI versions will have some time to upgrade before we start OOTB recommending newest eslint. See #735 (comment) Intended to be reverted ~1 week after next plugins release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eslint@9.0.0 was released and with it a major change to how eslint is configured. The migration process is nontrivial and may not be an option/priority for every project. Additionally, upgrading will loudly fail unless you have accounted for the config. Accordingly, I have done the following:
direct_configsa property ofcommands, allowing us to version the configs that are applicable for lintereslinttests to handle pre- and post- eslint9eslint9flat configeslint9This will requires a minimum version bump to support. Most of the files changes are lockfiles.