Several improvements #115
Closed
Several improvements #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After that PR, agent forwarding started working for me |
lonnywong
reviewed
May 25, 2024
| @@ -1178,10 +1178,12 @@ func sshAgentForward(args *sshArgs, param *sshParam, client *ssh.Client, session | |||
| warning("forward agent but the socket address is not set") | |||
| return | |||
| } | |||
| if err := forwardToRemote(client, addr); err != nil { | |||
|
|
|||
| if err := agent.ForwardToAgent(client, getAgentClient(args, param)); err != nil { | |||
There was a problem hiding this comment.
1password doesn't support keep using the same agent connection. #51
| }) | ||
|
|
||
| // Ssh agent forwarding must start before session.Shell or session.Command. | ||
| agentForwarding = func() { |
| conn.Close() | ||
| agentClient = nil | ||
| }) | ||
| if args.ForwardAgent { |
There was a problem hiding this comment.
There are also args.NoForwardAgent and strings.ToLower(getOptionConfig(args, "ForwardAgent")) == "yes".
| // Let's postpone forwarding - maybe we won't have to do it. | ||
| afterLoginFuncs = append(afterLoginFuncs, func() { | ||
| // ssh forward | ||
| sshForward(ss.client, args, param) |
There was a problem hiding this comment.
The warning message should be output before logging in, but now it may be output after logging in.
| conn, err := winio.DialPipe(addr, &timeout) | ||
|
|
||
| if err != nil { // Plan B. | ||
| conn, err = pageant.NewConn() |
There was a problem hiding this comment.
Should check whether openssh agent or pageant is currently running first.
|
pageant merged with changes as b518f22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.