-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 #956
Conversation
Important Auto Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
packages/ts-graphviz/src/ast/dot-shim/printer/plugins/utils/tokens.ts
Fixed
Show resolved
Hide resolved
🫰✨ Thanks @kamiazya! Your snapshots have been published to npm. Test the snapshots by updating your # Use npm
npm install "@ts-graphviz/adapter"
# Use yarn
yarn add "@ts-graphviz/adapter"
# Use pnpm
pnpm add "@ts-graphviz/adapter" # Use npm
npm install "@ts-graphviz/ast"
# Use yarn
yarn add "@ts-graphviz/ast"
# Use pnpm
pnpm add "@ts-graphviz/ast" # Use npm
npm install "@ts-graphviz/common"
# Use yarn
yarn add "@ts-graphviz/common"
# Use pnpm
pnpm add "@ts-graphviz/common" # Use npm
npm install "@ts-graphviz/core"
# Use yarn
yarn add "@ts-graphviz/core"
# Use pnpm
pnpm add "@ts-graphviz/core" # Use npm
npm install @ts-graphviz/adapter@0.0.0-pr956-20240225073457
# Use yarn
yarn add @ts-graphviz/adapter@0.0.0-pr956-20240225073457
# Use pnpm
pnpm add @ts-graphviz/adapter@0.0.0-pr956-20240225073457 # Use npm
npm install @ts-graphviz/ast@0.0.0-pr956-20240225073457
# Use yarn
yarn add @ts-graphviz/ast@0.0.0-pr956-20240225073457
# Use pnpm
pnpm add @ts-graphviz/ast@0.0.0-pr956-20240225073457 # Use npm
npm install @ts-graphviz/common@0.0.0-pr956-20240225073457
# Use yarn
yarn add @ts-graphviz/common@0.0.0-pr956-20240225073457
# Use pnpm
pnpm add @ts-graphviz/common@0.0.0-pr956-20240225073457 # Use npm
npm install @ts-graphviz/core@0.0.0-pr956-20240225073457
# Use yarn
yarn add @ts-graphviz/core@0.0.0-pr956-20240225073457
# Use pnpm
pnpm add @ts-graphviz/core@0.0.0-pr956-20240225073457 # Use npm
npm install ts-graphviz@0.0.0-pr956-20240225073457
# Use yarn
yarn add ts-graphviz@0.0.0-pr956-20240225073457
# Use pnpm
pnpm add ts-graphviz@0.0.0-pr956-20240225073457 |
/snapshot-release |
🫰✨ Thanks @kamiazya! Your snapshots have been published to npm. Test the snapshots by updating your # Use npm
npm install "@ts-graphviz/adapter"
# Use yarn
yarn add "@ts-graphviz/adapter"
# Use pnpm
pnpm add "@ts-graphviz/adapter" # Use npm
npm install "@ts-graphviz/ast"
# Use yarn
yarn add "@ts-graphviz/ast"
# Use pnpm
pnpm add "@ts-graphviz/ast" # Use npm
npm install "@ts-graphviz/common"
# Use yarn
yarn add "@ts-graphviz/common"
# Use pnpm
pnpm add "@ts-graphviz/common" # Use npm
npm install "@ts-graphviz/core"
# Use yarn
yarn add "@ts-graphviz/core"
# Use pnpm
pnpm add "@ts-graphviz/core" # Use npm
npm install @ts-graphviz/adapter@0.0.0-pr956-20240225091623
# Use yarn
yarn add @ts-graphviz/adapter@0.0.0-pr956-20240225091623
# Use pnpm
pnpm add @ts-graphviz/adapter@0.0.0-pr956-20240225091623 # Use npm
npm install @ts-graphviz/ast@0.0.0-pr956-20240225091623
# Use yarn
yarn add @ts-graphviz/ast@0.0.0-pr956-20240225091623
# Use pnpm
pnpm add @ts-graphviz/ast@0.0.0-pr956-20240225091623 # Use npm
npm install @ts-graphviz/common@0.0.0-pr956-20240225091623
# Use yarn
yarn add @ts-graphviz/common@0.0.0-pr956-20240225091623
# Use pnpm
pnpm add @ts-graphviz/common@0.0.0-pr956-20240225091623 # Use npm
npm install @ts-graphviz/core@0.0.0-pr956-20240225091623
# Use yarn
yarn add @ts-graphviz/core@0.0.0-pr956-20240225091623
# Use pnpm
pnpm add @ts-graphviz/core@0.0.0-pr956-20240225091623 # Use npm
npm install ts-graphviz@0.0.0-pr956-20240225091623
# Use yarn
yarn add ts-graphviz@0.0.0-pr956-20240225091623
# Use pnpm
pnpm add ts-graphviz@0.0.0-pr956-20240225091623 |
/snapshot-release |
🫰✨ Thanks @kamiazya! Your snapshots have been published to npm. Test the snapshots by updating your # Use npm
npm install "@ts-graphviz/adapter"
# Use yarn
yarn add "@ts-graphviz/adapter"
# Use pnpm
pnpm add "@ts-graphviz/adapter" # Use npm
npm install "@ts-graphviz/ast"
# Use yarn
yarn add "@ts-graphviz/ast"
# Use pnpm
pnpm add "@ts-graphviz/ast" # Use npm
npm install "@ts-graphviz/common"
# Use yarn
yarn add "@ts-graphviz/common"
# Use pnpm
pnpm add "@ts-graphviz/common" # Use npm
npm install "@ts-graphviz/core"
# Use yarn
yarn add "@ts-graphviz/core"
# Use pnpm
pnpm add "@ts-graphviz/core" # Use npm
npm install @ts-graphviz/adapter@0.0.0-pr956-20240225160253
# Use yarn
yarn add @ts-graphviz/adapter@0.0.0-pr956-20240225160253
# Use pnpm
pnpm add @ts-graphviz/adapter@0.0.0-pr956-20240225160253 # Use npm
npm install @ts-graphviz/ast@0.0.0-pr956-20240225160253
# Use yarn
yarn add @ts-graphviz/ast@0.0.0-pr956-20240225160253
# Use pnpm
pnpm add @ts-graphviz/ast@0.0.0-pr956-20240225160253 # Use npm
npm install @ts-graphviz/common@0.0.0-pr956-20240225160253
# Use yarn
yarn add @ts-graphviz/common@0.0.0-pr956-20240225160253
# Use pnpm
pnpm add @ts-graphviz/common@0.0.0-pr956-20240225160253 # Use npm
npm install @ts-graphviz/core@0.0.0-pr956-20240225160253
# Use yarn
yarn add @ts-graphviz/core@0.0.0-pr956-20240225160253
# Use pnpm
pnpm add @ts-graphviz/core@0.0.0-pr956-20240225160253 # Use npm
npm install ts-graphviz@0.0.0-pr956-20240225160253
# Use yarn
yarn add ts-graphviz@0.0.0-pr956-20240225160253
# Use pnpm
pnpm add ts-graphviz@0.0.0-pr956-20240225160253 |
@coderabbitai review |
🦋 Changeset detectedLatest commit: f673adc The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
/snapshot-release |
🫰✨ Thanks @kamiazya! Your snapshots have been published to npm. Test the snapshots by updating your # Use npm
npm install "@ts-graphviz/adapter"
# Use yarn
yarn add "@ts-graphviz/adapter"
# Use pnpm
pnpm add "@ts-graphviz/adapter" # Use npm
npm install "@ts-graphviz/ast"
# Use yarn
yarn add "@ts-graphviz/ast"
# Use pnpm
pnpm add "@ts-graphviz/ast" # Use npm
npm install "@ts-graphviz/common"
# Use yarn
yarn add "@ts-graphviz/common"
# Use pnpm
pnpm add "@ts-graphviz/common" # Use npm
npm install "@ts-graphviz/core"
# Use yarn
yarn add "@ts-graphviz/core"
# Use pnpm
pnpm add "@ts-graphviz/core" # Use npm
npm install @ts-graphviz/adapter@0.0.0-pr956-20240225163634
# Use yarn
yarn add @ts-graphviz/adapter@0.0.0-pr956-20240225163634
# Use pnpm
pnpm add @ts-graphviz/adapter@0.0.0-pr956-20240225163634 # Use npm
npm install @ts-graphviz/ast@0.0.0-pr956-20240225163634
# Use yarn
yarn add @ts-graphviz/ast@0.0.0-pr956-20240225163634
# Use pnpm
pnpm add @ts-graphviz/ast@0.0.0-pr956-20240225163634 # Use npm
npm install @ts-graphviz/common@0.0.0-pr956-20240225163634
# Use yarn
yarn add @ts-graphviz/common@0.0.0-pr956-20240225163634
# Use pnpm
pnpm add @ts-graphviz/common@0.0.0-pr956-20240225163634 # Use npm
npm install @ts-graphviz/core@0.0.0-pr956-20240225163634
# Use yarn
yarn add @ts-graphviz/core@0.0.0-pr956-20240225163634
# Use pnpm
pnpm add @ts-graphviz/core@0.0.0-pr956-20240225163634 # Use npm
npm install ts-graphviz@0.0.0-pr956-20240225163634
# Use yarn
yarn add ts-graphviz@0.0.0-pr956-20240225163634
# Use pnpm
pnpm add ts-graphviz@0.0.0-pr956-20240225163634 |
Why?
Dropping support for Node.js 14 & 16
We are introducing a major version upgrade to ts-graphviz to ensure better performance, security, and compatibility with the latest improvements in the JavaScript ecosystem. With this upgrade, we will no longer support Node.js 14 & 16, which has reached its End-of-Life (EOL), and set the new minimum guaranteed version to Node.js 18.
This major version upgrade is necessary due to the following reasons:
Breaking Change: Dropping support for Node.js 14 & 16 is considered a breaking change, which requires a major version upgrade according to semantic versioning principles.
Improved Stability and Performance: By focusing on LTS versions, we can provide a library that benefits from the stability, long-term support, and performance improvements provided by newer Node.js versions.
Security: Ensuring that our library is compatible with the latest supported Node.js versions helps to minimize potential security vulnerabilities.
To help our users understand our approach to Node.js version support, we have established a clear Node.js Version Support Policy for ts-graphviz.
We encourage our users to update their projects to the latest LTS version of Node.js to ensure the best performance, security, and compatibility with ts-graphviz.
Key Concepts
ts-graphviz is a TypeScript library designed to create, manipulate, and render Graphviz DOT language graphs.
It is built around several key concepts that make it modular, extensible, and easy to use:
TypeScript-First Design & Type Definitions: ts-graphviz is designed with TypeScript as its primary language, providing strong typing and ensuring seamless integration with TypeScript projects. This enables users to leverage the full power of TypeScript's type system and tooling while working with Graphviz graphs. The library includes comprehensive type definitions for DOT language elements, making it easier to work with Graphviz elements in a type-safe manner.
Object-Oriented API: ts-graphviz provides an object-oriented API for creating and manipulating graph elements like graphs, nodes, and edges. This enables users to work with complex graph structures intuitively and efficiently.
Modular Design[New in v2]: The library is split into multiple packages, each serving a specific purpose. This modular design allows users to pick and choose the functionality they need, resulting in improved maintainability and flexibility.
AST Support: ts-graphviz includes a module for processing DOT language at the Abstract Syntax Tree (AST) level. This feature allows users to parse and generate DOT language while preserving its structure, making it easier to manipulate and transform graphs programmatically.
Runtime Adapter: The library provides adapter functions that enable users to execute Graphviz commands across different runtime environments, such as Node.js and Deno. These adapter functions serve as a wrapper, allowing for seamless integration with various platforms.
Extensibility: ts-graphviz has been designed with extensibility in mind, allowing users to extend its functionality with custom implementations for specific use cases.
Multi-Paradigm Support: ts-graphviz is designed to accommodate various programming paradigms, such as Object-Oriented Programming, Declarative Programming, and Functional Programming. This ensures that users can choose the programming style that best suits their needs and preferences, making it adaptable and versatile across different use cases and development approaches.
By combining these key concepts, ts-graphviz aims to provide a powerful and user-friendly tool for working with Graphviz DOT language in TypeScript projects.
What's changed?
Package splitting and monorepo-ization
Purpose
The purpose of package splitting and monorepo-ization in the ts-graphviz v2 is to achieve the following objectives:
Overall, package splitting and monorepo-ization aim to create a more robust, maintainable, and user-friendly library that better serves the needs of the ts-graphviz community.
Packages
In v2 of ts-graphviz, the library functionality will be split into several packages. The packages to be split are as follows:
To ensure that existing users are not affected, the ts-graphviz package will remain available. This change will result in a clear division of functionality and will improve the scalability and maintainability of the project. However, users of previous versions and users who wish to use the library without extending it will be able to continue to use the ts-graphviz package as is.
Please note that while we strive to maintain compatibility, there might be some minor differences or limitations in the compatibility package compared to the original ts-graphviz library. It is essential to review the documentation and update your code accordingly if needed, but only when you decide to migrate to the new package structure.
Dependency graph
Node.js Version Support Update
Starting with the upcoming release, ts-graphviz will no longer support Node.js 14 & 16, which has reached its End-of-Life (EOL). The new minimum guaranteed version will be Node.js 18. This decision allows us to focus on providing a secure and up-to-date library while minimizing the maintenance burden of supporting outdated versions.
To minimize disruption for our users, we have established a clear Node.js Version Support Policy for our library. This policy helps users understand our approach to Node.js version support and what to expect when using our library.
We encourage our users to update their projects to the latest LTS version of Node.js to ensure the best performance, security, and compatibility with ts-graphviz.
Node.js Version Support Policy
Our goal is to provide a stable and secure library for our users while keeping up with improvements in the JavaScript ecosystem. To achieve this, we have established the following Node.js version support policy for ts-graphviz:
Minimum Guaranteed Version: We guarantee support for the latest Node.js version that has entered Long-Term Support (LTS) at the time of a major release of our library. This ensures that our library benefits from the stability and long-term support provided by LTS versions.
End-of-Life (EOL) Policy: We will cease support for Node.js versions when they reach their EOL, as defined by the Node.js release schedule. This helps us focus on providing a secure and up-to-date library while minimizing the maintenance burden of supporting outdated versions.
Version Support Communication: We will communicate our Node.js version support policy in our library's documentation and release notes. When a new major version is released or when a Node.js version enters EOL, we will inform our users through release notes, blog posts, or other relevant channels.
Migration Guides : When introducing breaking changes due to Node.js version support updates, we will provide migration guides to help our users transition their projects to the new requirements smoothly.
Migration Guides
Update Node.js Version
To migrate to the new Node.js version support policy, follow these steps:
By following these steps, you can migrate your project to the latest LTS version of Node.js and ensure compatibility with ts-graphviz.
Migrate
AttributeKeyDict
type toAttribute.keys
typeAttributeKeyDict
was deprecated in v1, so it was removed in v2.Please modify to use
Attribute.keys
.Migrate
ts-graphviz/adapter
to@ts-graphviz/adapter
To migrate from the
ts-graphviz/adapter
module to the@ts-graphviz/adapter
module, follow these steps:Update Import Statements: Update import statements in your code to use the new module name.
Update Package.json: Update the
ts-graphviz
dependency in yourpackage.json
file to use the new version of the@ts-graphviz/adapter
module.Update Code References: Search your codebase for any references to the
ts-graphviz/adapter
module and update them to use the new module name.Migrate
ts-graphviz/ast
to@ts-graphviz/ast
To migrate from the
ts-graphviz/adapter
module to the@ts-graphviz/adapter
module, follow these steps:Update Import Statements: Update import statements in your code to use the new module name.
Update Package.json: Update the
ts-graphviz
dependency in yourpackage.json
file to use the new version of the@ts-graphviz/ast
module.Update Code References: Search your codebase for any references to the
ts-graphviz/ast
module and update them to use the new module name.Migrate Extending the Type System
Common types moves to
@ts-graphviz/common
in v2.0.0.If you have extended the type system, you need to update the import path.
Use Case: Specifying Custom Graph Layout and Output Formats
Use Case: Adding Custom Attributes
Development
Package manager
Migration from yarn v1 to pnpm has been done for package management.
Build tool and Test suite
To enhance the development experience, the build tool has been changed from rollup to vite, and the test suite from jest to vitest. This was done because jest lacked standard support for monorepo integration and TypeScript, requiring the installation of additional plugins. However, vite and vitest handle these challenges more elegantly, providing a smoother and more efficient development workflow.
Release flow
The release flow has been updated to use the changeset tool to manage changes and releases.
This tool allows for a more streamlined and automated release process, making it easier to manage versioning and changelogs across multiple packages within the monorepo.
Linter an Formatter
The linter and formatter have been updated to use biome, respectively.
This change was made to ensure consistent code style and formatting across the entire codebase, making it easier to maintain and contribute to the project.
API Changes
@microsoft/api-extractor
specification used internally in the d.ts file rollup.