Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change regex for recognizing errors in the syslog format #824

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rzadp
Copy link

@rzadp rzadp commented Jan 1, 2021

I have found that err is used as an alias to error.
Changing the regex to catch err would work for both usages.

@nodiscc
Copy link
Contributor

nodiscc commented Jan 23, 2023

This would result in a huge number of false positives since many messages that are not errors contain the string err (see also #733).

I suggest not merging this as-is (and instead use overrides like documented in https://docs.lnav.org/en/latest/formats.html, #1113 improves the docs a bit). For me this would result in false positives for all messages containing referral, override overridden, deferred, preferred, interrupt, providerruntime, ownerrole ... Many randomly generated strings/IDs are also likely to contain err.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants