Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated toolchain, impoved multiselects and compatibility to select2 4.1 #56

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

weberhofer
Copy link

No description provided.

Signed-off-by: Johannes Weberhofer <jweberhofer@weberhofer.at>
Signed-off-by: Johannes Weberhofer <jweberhofer@weberhofer.at>
This was referenced Jul 2, 2020
@weberhofer weberhofer changed the title Updated compiled CSS files Updated toolchan, impoved multiselects and compatibility to select2 4.1 Jul 2, 2020
@weberhofer weberhofer changed the title Updated toolchan, impoved multiselects and compatibility to select2 4.1 Updated toolchain, impoved multiselects and compatibility to select2 4.1 Jul 2, 2020
@weberhofer
Copy link
Author

This RP fixes #49

@weberhofer weberhofer mentioned this pull request Jul 3, 2020
@ttskch
Copy link
Owner

ttskch commented Jan 24, 2021

@weberhofer Thanks for your contribution! I updated toolchain on 993dea8 . And I cannot merge this PR to master branch because it breaks BC for users of select2 4.0. I will create a new branch to support select2 4.1. Please wait a moment. Thanks.

@tagliala
Copy link
Contributor

Hi @ttskch

Select 2 4.1 is now in RC. Most of the things already seems to work, if you create a branch I can help to check the missing ones

@tagliala
Copy link
Contributor

This branch contains an opinionated reimplementation of this theme working with Select2 4.1 RC0

I've used Bootstrap 4's custom-select to improve uniformity

I've tested on:

  • latest Safari macOS 10.15
  • latest Chrome macOS 10.15
  • latest Firefox macOS 10.15
  • latest Chrome on Windows 10
  • latest Firefox on Windows 10
  • latest Edge on Windows 10
  • IE11 on Windows 10

I can't test on IE 10

@NordicAT
Copy link

NordicAT commented Mar 2, 2021

@tagliala
I have tested your reimplementation. I like it, but there seems to be a bug with an empty multiselect.
Have a look at the following screenshot:

Select2-Multiselect

@tagliala
Copy link
Contributor

tagliala commented Mar 2, 2021

@NordicAT thanks. I've opened a new PR at #67

I like it, but there seems to be a bug with an empty multiselect.

I've added some extra fields to the demo for testing purposes. Any chance to share the original HTML so I can reproduce?

@tagliala
Copy link
Contributor

tagliala commented Mar 2, 2021

@NordicAT nope. Tested on windows chrome / firefox / edge / ie11

Can we continue at #67? we are off topic here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants