Only allow mouse button 0 to open links in 'mousedown' event #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix typo for 'isReadOn(l)y'
|
@tulios Why does this mousedown override exist at all, when the ext already makes links clickable (and can therefore add target=_blank on those anchor tags in the first place)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, clicking any mouse button on a link will cause it to open the link; this prevents using e.g. right-click context menu on the link, and may grab mouse4/mouse5 inputs and use them as regular clicks. This change makes it so this mousedown override only applies to M1 (usually left click, but should support users that flip their mouse buttons as well).
Also fix typo for 'isReadOn(l)y'