[KIP-601] Increase connection timeout #1627
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
being closer to the defaults in KIP-601
|
Thanks for this PR @emasab I think it's important to bump this limit too @Nevon - otherwise it makes the client too fragile to connection storm issues - we've seen cases where clients connect to brokers at once and due to either throttling or simple overload of the acceptor thread in Kafka, the broker can take more than a second to establish the connection. If clients are too sensitive to this timeout, they risk perpetuating the issue |
There was a problem hiding this comment.
We should edit this excerpt too: https://github.com/tulios/kafkajs/blob/master/docs/Configuration.md#connection-timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
being closer to the defaults in KIP-601.
In KafkaJS the connection establishment limit corresponds to the
connectionTimeout+authenticationTimeout.authenticationTimeouthas been increased to 10s, butconnectionTimeoutis 1s.KIP-601
socket.connection.setup.timeout.msis about connection and in librdkafka corresponds to 30s, while in kafka-clients is exponential from a minimum ofsocket.connection.setup.timeout.ms(10s) to a maximum ofsocket.connection.setup.timeout.max.ms(30s).This reduces the gap by setting the minimum to 10s and the sum of them to 20s.