Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some known issues have been fixed #166

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Some known issues have been fixed #166

wants to merge 2 commits into from

Conversation

kebyn
Copy link

@kebyn kebyn commented Mar 12, 2022

  1. Fix code formatting according to go-staticcheck
  2. Some known issues have been fixed

@ZenithalHourlyRate
Copy link
Contributor

2. known issues

Please elaborate on this.

@kebyn
Copy link
Author

kebyn commented Mar 23, 2022

  1. known issues

Please elaborate on this.

  1. Use variable number of arguments instead of range
  2. From the time.Tick documentation:

Tick is a convenience wrapper for NewTicker providing access to the ticking channel only. While Tick is useful for clients that have no need to shut down the Ticker, be aware that without a way to shut it down the underlying Ticker cannot be recovered by the garbage collector; it "leaks". Unlike NewTicker, Tick will return nil if d <= 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants