deps: Update to eslint-config-transloadit@v2

[mifi]

See transloadit/eslint-config-transloadit#13

biggest changes due to I pulled out Source classes into separate files.
I also simplified eslintrc (much of it is inherited from eslint-config-transloadit)

[Acconut]

Thanks for the PR, but the linting process now generates some errors and tons of warning. The errors must be looked into and the warnings make the entire linter a bit useless since you are just flooded with them.

Before we merge this PR, we need to look into the error and warning to see which code needs to be adapted and which rules we have to disable or adjust.

[mifi]

Yup I just realized there’s something wrong which I didnt get when i ran it locally, gonna look into that. As for warnings, many of them (531) were already there prior to this PR, but now there are 887, most of which come from the no-underscore-dangle. I think i’ll just completely disable that rule as it seems to be used a lot here.
I agree that it’s a lot of noise, so we should ideally fix all the warning issues and then change the rule to error instead (remove the warn overrides in the project) but maybe that should be done in a different pr?

[mifi]

Alright I think I "fixed" the errors. Because eslint cannot find imported dist files for the tests before build has been run, it will fail during github actions run. I disabled the rules in the test files.

As for the warnings, shall we just try to run an eslint --fix and see what it can fix, maybe in a separate PR?

[Acconut]

Because eslint cannot find imported dist files for the tests before build has been run, it will fail during github actions run. I disabled the rules in the test files.

Ok, in that case it would make sense to first run he build test and then the lint step. Would that help us with re-enabling the rules again?

As for warnings, many of them (531) were already there prior to this PR, but now there are 887, most of which come from the no-underscore-dangle. I think i’ll just completely disable that rule as it seems to be used a lot here.

Wow, I wasn't aware that we have so many warnings. Thanks for taking care of no-underscore-dangle.

As for the warnings, shall we just try to run an eslint --fix and see what it can fix, maybe in a separate PR?

Yes, we can try that in a separate PR. We have to discuss how far we should go with eslint --fix. For example, the code in /demos/browser/ is supposed to run un-compiled in the browser. So for every modern feature used in there, we have to consider which browsers it is supported in (e.g. const/let vs var)

[mifi]

Ok, in that case it would make sense to first run he build test and then the lint step. Would that help us with re-enabling the rules again?

good idea. I did that.

Yes, we can try that in a separate PR. We have to discuss how far we should go with eslint --fix. For example, the code in /demos/browser/ is supposed to run un-compiled in the browser. So for every modern feature used in there, we have to consider which browsers it is supported in (e.g. const/let vs var)

We can exclude demos from eslint maybe. May not be that important that they are linted?

[Acconut]

Let's merge it now and figure out a solution to all of the warning in a separate PR :) Thanks for your work!