fix buffer initialization in base64 encoding in node #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a number was passed to `encode()`, the buffer would be created with uninitialised memory. This patch casts anything that's passed in to a string first and then uses the safe `Buffer.from` API. `Buffer.from` was added in Node v4 but the `buffer-from` module ponyfills it for older Node versions. See [nodejs/node#4660](nodejs/node#4660)
|
Ouch, it hurts seeing such errors arise in JavaScript. Thank you a lot for solving this. Could you please address the one linting issue? https://travis-ci.org/tus/tus-js-client/jobs/237541799#L428 |
|
Done :) |
Acconut
added a commit
that referenced
this pull request
May 30, 2017
commit 3827da752d3b2eb86613b92ffb6715806d799fdc
Author: Marius <maerious@gmail.com>
Date: Tue May 30 21:31:26 2017 +0200
Transpile changes
commit 025aac69f827e6c0f51215609070bab6b76cc491
Author: Marius <maerious@gmail.com>
Date: Tue May 30 21:30:41 2017 +0200
Add test for number metadata
commit 35b470af8386ff96230e09408a3ba83c6831b3a0
Merge: 902e4bf 74e4500
Author: Marius <maerious@gmail.com>
Date: Tue May 30 21:26:52 2017 +0200
Merge branch 'fix/buffer-leak' of https://github.com/goto-bus-stop/tus-js-client into buffer
commit 74e4500
Author: Renée Kooi <renee@kooi.me>
Date: Tue May 30 17:18:44 2017 +0200
fix lint
commit a420570
Author: Renée Kooi <renee@kooi.me>
Date: Tue May 30 15:43:13 2017 +0200
fix buffer initialization in base64 encoding
If a number was passed to `encode()`, the buffer would be created with
uninitialised memory. This patch casts anything that's passed in to
a string first and then uses the safe `Buffer.from` API. `Buffer.from`
was added in Node v4 but the `buffer-from` module ponyfills it for older
Node versions.
See [nodejs/node#4660](nodejs/node#4660)
|
Thank you, I added a test and merged in 66694b4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a number was passed to
encode(), the buffer would be created withuninitialised memory. This patch casts anything that's passed in to
a string first and then uses the safe
Buffer.fromAPI.Buffer.fromwas added in Node v4 but the
buffer-frommodule ponyfills it for olderNode versions.
See nodejs/node#4660