Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in S3 delete expired tests #533

Open
Murderlon opened this issue Dec 14, 2023 · 1 comment · May be fixed by #534
Open

Fix race condition in S3 delete expired tests #533

Murderlon opened this issue Dec 14, 2023 · 1 comment · May be fixed by #534

Comments

@Murderlon
Copy link
Member

Regularly seeing a race condition occurring when two CI runs happen around the same time, which happens often if you have multiple PRs or a PR and a new commit in main.

Details: https://github.com/tus/tus-node-server/actions/runs/7206763772/job/19632235153

@fenos
Copy link
Collaborator

fenos commented Dec 14, 2023

Yes, this is a tricky one to fix, since they both try to call s3.deleteExpired() resulting in deleting each other files and the assertion then fails.

maybe we can create a new bucket with a random name during the tests and delete it right after

@fenos fenos linked a pull request Dec 14, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants