Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: s3 e2e tests race condition #534

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fenos
Copy link
Collaborator

@fenos fenos commented Dec 14, 2023

This PR create a new random bucket every time tests runs avoiding race conditions

closes #533

@fenos fenos force-pushed the fix/aws-e2e-tests-race-condition branch 13 times, most recently from 770ff30 to 1fb60ef Compare December 14, 2023 13:22
@fenos fenos force-pushed the fix/aws-e2e-tests-race-condition branch from 1fb60ef to ddd1f6b Compare December 18, 2023 10:45
@fenos
Copy link
Collaborator Author

fenos commented Dec 18, 2023

tests are now also giving:

InvalidAccessKeyId: The AWS Access Key Id you provided does not exist in our records.

@Murderlon
Copy link
Member

Check Discord for what happend :)

I'm putting new permissions in place so we're going to have to find an alternative that doesn't involve creating and deleting new buckets. Perhaps we can work with prefixes or tags to differentiate between runners which files to delete?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix race condition in S3 delete expired tests
2 participants