Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GridFS support #526

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Add GridFS support #526

wants to merge 23 commits into from

Conversation

spencerjibz
Copy link

@spencerjibz spencerjibz commented Dec 4, 2023 •
edited

Background

Hi there, I have used gridFS for a while now, so recently thought might as well build a tus-store for it, I know there was a related issue to this back in 2016.

Implementation Details

  • Extended MongoDB's gridfs write stream to support updating existing files. (can contribute this back to the mongo repo later).
  • Added a config Store for usage, internally used by the store package, but can also be used separately with other stores(FileStore).
  • Modified the demos to include the new store.
  • Added tests for the new store and also a MongoDB-in-memory server for tests and CI
  • Added e2e test for the gridfs-store

Let me know if there are any changes you'd like me to make.

Spencerjibz and others added 16 commits November 25, 2023 23:43
add gridfs-store template
f1c232b
add dependences for @tus/gridfs-store workspace
e7cbee7
Add GridFSStore class for MongoDB GridFS storage
6d78afb
Add support for extensions in GridFsStore
4087a63
add required gridfs indexes, fix set deferred_upload_length
c387113
Add MongodbConfigStore for storing upload data in MongoDB
b62830c
Update interface type definition for Configstore
60318de
@spencerjibz
Merge branch 'tus:main' into main
0a14d4f
manually destroy the readable out to fix tests from hanging in node v17+
9138926
@spencerjibz
Merge branch 'tus:main' into main
a8faf9b
added a mongodb config store and modified gridfWriteStream to support…
1e07e4a 
… updating existing files
complete store implementation with new mongoutils
7a84d6b
added tests for gridfsstore and needed test dependencies
87c5962
add gridfsStore demo and mongodb-memory-server for tests and CI
addfc2b
Merge branch 'main' of https://github.com/spencerjibz/tus-node-server
9a2575e
add a docs for the gridfs store
05594c8
@spencerjibz spencerjibz marked this pull request as draft December 4, 2023 09:42
@spencerjibz spencerjibz marked this pull request as ready for review December 4, 2023 09:42
@spencerjibz spencerjibz marked this pull request as draft December 5, 2023 09:02
@spencerjibz
Copy link
Author

spencerjibz commented Dec 5, 2023 •
edited

Just realised, l need to add e2e tests for the new store.

@spencerjibz spencerjibz marked this pull request as ready for review December 5, 2023 18:51
@Murderlon
Copy link
Member

Thanks a lot for the massive contribution. Because this is a big PR, it will require a deep dive review for which I don't have time now but I'll come back to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spencerjibz @Murderlon