Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #566

Closed
wants to merge 1 commit into from
Closed

Version Packages #566

wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@tus/server@1.4.0

Minor Changes

  • 1a4339a: Support async namingFunction

@tus/file-store@2.0.0

Patch Changes

  • Updated dependencies [1a4339a]
    • @tus/server@1.4.0

@tus/gcs-store@2.0.0

Patch Changes

  • Updated dependencies [1a4339a]
    • @tus/server@1.4.0

@tus/s3-store@2.0.0

Patch Changes

  • Updated dependencies [1a4339a]
    • @tus/server@1.4.0

demo@null

demo

null

Patch Changes

  • Updated dependencies [1a4339a]
    • @tus/server@1.4.0
    • @tus/file-store@2.0.0
    • @tus/gcs-store@2.0.0
    • @tus/s3-store@2.0.0

test@null

test

null

Patch Changes

  • Updated dependencies [1a4339a]
    • @tus/server@1.4.0
    • @tus/file-store@2.0.0
    • @tus/gcs-store@2.0.0
    • @tus/s3-store@2.0.0

Copy link
Member

@Murderlon Murderlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems I did something incorrectly.

@Murderlon
Copy link
Member

Bit annoying that every time server is published, all packages are published because of this bug: changesets/changesets#1290

@Murderlon Murderlon closed this Jan 26, 2024
@Murderlon Murderlon deleted the changeset-release/main branch January 26, 2024 10:44
@Murderlon
Copy link
Member

This is also very unfortunate: changesets/changesets#1011

Currently, if you list a package as a peerDependency of another package, this causes the package with the peerDependency to be released as a major change. This is because peerDependency changes will not be caught by a package installation.

This decision is open for discussion.

@tus/server is a peerDependency everywhere so that's problematic. One solution could be to make a @tus/utils package with shared types and models. But that's arguably a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant