4083 limit dialog sizes #4084
Draft
4083 limit dialog sizes #4084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lakoja
commented
Oct 29, 2023
| @@ -78,3 +81,15 @@ fun TextView.fixTextSelection() { | |||
| setTextIsSelectable(false) | |||
| post { setTextIsSelectable(true) } | |||
| } | |||
|
|
|||
| fun Float.dpToPx(resource: Resources): Float { | |||
There was a problem hiding this comment.
We didn't have those, yet?
| maxHeightSpec = maxAvailablePixels.height | ||
| } | ||
|
|
||
| this.setLayout(maxWidthSpec, maxHeightSpec) |
There was a problem hiding this comment.
Draft..
However this leads to this size being fixed. I. e. SOFT_INPUT_ADJUST_RESIZE not working anymore: Once the keyboard is visible half the (caption) dialog is covered and not scrollable...
| if (maxWidthDp == ViewGroup.LayoutParams.MATCH_PARENT && maxHeightDp == ViewGroup.LayoutParams.MATCH_PARENT) { | ||
| this.setLayout(ViewGroup.LayoutParams.MATCH_PARENT, ViewGroup.LayoutParams.MATCH_PARENT) | ||
| } else { | ||
| val maxAvailablePixels = getAvailableScreenPixels(this) |
There was a problem hiding this comment.
Anyway: I have the feeling this could be a one-line configuration somewhere. E. g. defining the right variable in a style and use that for dialogs?
Lakoja
commented
Jan 3, 2024
| } | ||
|
|
||
| private fun getAvailableScreenPixels(window: Window): Size { | ||
| val windowInsets = window.windowManager.maximumWindowMetrics.windowInsets |
There was a problem hiding this comment.
Draft
Unfortunately all methods and fields in this method are api level 30 (and not 24).
The task should be simple: Get size available to / used by app window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4083
Limits the size of full screen dialogs on larger devices.