Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use build plugins to generate wasm glue & fallback #6835

Closed
15 tasks done
murilopereirame opened this issue Apr 5, 2024 · 0 comments · Fixed by #6868
Closed
15 tasks done

Use build plugins to generate wasm glue & fallback #6835

murilopereirame opened this issue Apr 5, 2024 · 0 comments · Fixed by #6868
Labels
state:done meets our definition of done state:tested We tested it and are about to release it
Milestone
230.240528.0

Comments

@murilopereirame
Copy link
Contributor

murilopereirame commented Apr 5, 2024 •
edited by wrdhub

As suggested here: #6814 (comment)

We would like to write a plugin for esbuild/rollup that does:

  • detect that WASM is loaded
  • generate WASM asset & JS fallback
  • generate code to detect WASM support at the loading phase
  • generate code to load & initialize either WASM or JS fallback

Test Notes

  • With WebAssembly enabled (Browser):
    • User is able to login in
    • User is able to create an account
    • Saved credentials still working
    • Saving credentials still working
    • Receiving/Sending post quantum protected emails works
    • Receiving/Sending normal emails works
    • Fallback isn't loaded (liboqs.js or argon2.js)
  • With WebAssembly disabled (Browser):
    • User is able to login in
    • User is able to create an account
    • Saved credentials still working
    • Saving credentials still working
    • Receiving/Sending post quantum protected emails works
    • Receiving/Sending normal emails works
  • Desktop Only
    • AppLock still working
    • Offline storage still working
@murilopereirame murilopereirame self-assigned this Apr 5, 2024
@charlag charlag mentioned this issue Apr 18, 2024
Closed
@charlag charlag changed the title Use esbuild to generate wasm fallback Use build plugins to generate wasm glue & fallback Apr 18, 2024
This was referenced Apr 18, 2024
Merged
Closed
@wrdhub wrdhub added the state:done meets our definition of done label May 17, 2024
@kib42 kib42 added this to the Notifications milestone May 21, 2024
@wrdhub wrdhub self-assigned this May 24, 2024
@wrdhub wrdhub added the state:tested We tested it and are about to release it label May 24, 2024
@wrdhub wrdhub removed their assignment May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
state:done meets our definition of done state:tested We tested it and are about to release it
Projects
None yet
Milestone
230.240528.0
Development

Successfully merging a pull request may close this issue.

Generate WASM/JS Fallback during build process tutao/tutanota
3 participants
@murilopereirame @kib42 @wrdhub