Generate WASM/JS Fallback during build process #6868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murilopereirame
force-pushed
the
wasm-loader-6835
branch
11 times, most recently
from
18f4d1c
to
af69158
Compare
charlag
reviewed
Apr 23, 2024
murilopereirame
force-pushed
the
wasm-loader-6835
branch
from
af69158
to
6d1ea5c
Compare
murilopereirame
changed the title
murilopereirame
force-pushed
the
wasm-loader-6835
branch
5 times, most recently
from
b4d3023
to
fa91cea
Compare
charlag
reviewed
May 7, 2024
murilopereirame
force-pushed
the
wasm-loader-6835
branch
from
ff30313
to
2664f2e
Compare
charlag
approved these changes
May 13, 2024
murilopereirame
force-pushed
the
wasm-loader-6835
branch
from
894b2c2
to
482840a
Compare
This commit adds the generation of a JavaScript transpile for the Liboqs and Argon2 WebAssembly files. This is done through wasm2js that's builtin on emcc. WASM/JS fallbacks use the same interface and reduce the extra type casting once initialized. Co-authored-by: wec43 <wec@tutao.de> Co-authored-by: paw <paw-hub@users.noreply.github.com>
This commit adds the generation of WASM files and their respective fallback to the build process.
Adapt the tests to work with the new format of loading the fallback and the wasm files. This commit also fixes the ESBuild function to correctly resolve the fallback and generate it. Remove the hardcoded make command and add the option to use a provided command instead of make. Also adds the possibility to provide env vars and a working dir for Wasm generation.
murilopereirame
force-pushed
the
wasm-loader-6835
branch
from
482840a
to
1d2dba5
Compare
Squashed and rebased |
murilopereirame
force-pushed
the
wasm-loader-6835
branch
from
1d2dba5
to
e4e74e1
Compare
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generates WASM artifact and it's fallback during the build without the need of check in the WASM files.
Closes #6835