[desktop] use electron safeStorage to store device keys #3742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganthern
force-pushed
the
use-safe-storage-3676
branch
from
456fc5b
to
275fec9
Compare
* renames PathUtils.swapFilename to replaceLastComponent
* provides a new impl for SecretStorage
* uses electron.safeStorage to encrypt the device key that then gets
stored in a file in app.getPath('userData')/safe_storage/
* from now on, per-user data is encrypted with a per-user key,
even for per-machine installs.
#3733
close #3676
ganthern
force-pushed
the
use-safe-storage-3676
branch
from
275fec9
to
c853f68
Compare
|
closing this because electron/electron#32206 doesn't get any reaction |
rezbyte
pushed a commit
that referenced
this pull request
Nov 22, 2023
Translated to TypeScript from PR #3742
bedhub
pushed a commit
that referenced
this pull request
Nov 23, 2023
Translated to TypeScript from PR #3742
ganthern
added a commit
that referenced
this pull request
Nov 23, 2023
Translated to TypeScript from PR #3742
ganthern
added a commit
that referenced
this pull request
Nov 23, 2023
Translated to TypeScript from PR #3742
ganthern
added a commit
that referenced
this pull request
Nov 24, 2023
Translated to TypeScript from PR #3742
ganthern
added a commit
that referenced
this pull request
Nov 24, 2023
Translated to TypeScript from PR #3742
ganthern
added a commit
that referenced
this pull request
Nov 27, 2023
Translated to TypeScript from PR #3742
murilopereirame
pushed a commit
that referenced
this pull request
Nov 27, 2023
Translated to TypeScript from PR #3742
murilopereirame
pushed a commit
that referenced
this pull request
Nov 27, 2023
Translated to TypeScript from PR #3742
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stored in a file in app.getPath('userData')/safe_storage/
even for per-machine installs.
#3733
close #3676