Add Android lint & test to GitHub CI #6741
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murilopereirame
force-pushed
the
kotlin-test-ci-6678
branch
from
08ecd3c
to
3186eb4
Compare
charlag
reviewed
Mar 19, 2024
This commit implements the Android Lint and Tests into the pipeline to check if everything is ok at least with the written unit tests. Closes #6678
murilopereirame
force-pushed
the
kotlin-test-ci-6678
branch
from
3186eb4
to
b8b12fe
Compare
murilopereirame
force-pushed
the
kotlin-test-ci-6678
branch
from
1bc3729
to
15925fc
Compare
charlag
approved these changes
Mar 19, 2024
rezbyte
reviewed
Mar 25, 2024
.github/workflows/kotlin-test.yml
Outdated
| push: | ||
| branches-ignore: | ||
| - master | ||
| paths: [ "app-android/**" ] |
There was a problem hiding this comment.
Suggested change
| paths: [ "app-android/**" ] | |
| paths: | |
| - 'app-android/**' |
I have discovered square brackets in YAML are not arrays and are not recognized as such by GitHub Actions. This is the style used by the GitHub Actions' documentation.
There was a problem hiding this comment.
both are supposed to be "sequences" in YAML, I wonder why "flow style" ones don't work
There was a problem hiding this comment.
Yeah, it's weird. My only other hypothesis is the different quotation marks. YAML handles wildcards differently depending on quote style from memory. It still does not make much sense to me either way to be honest.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the Android Lint and Tests into the pipeline to check if everything is ok at least with the written unit tests.
Closes #6678