add buildSrc/checkVendoredVersions.js to .github/workflows/test.yml #6906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganthern
force-pushed
the
prevent-wrong-vendoring
branch
4 times, most recently
from
7b5407a
to
022535e
Compare
ganthern
force-pushed
the
prevent-wrong-vendoring
branch
from
022535e
to
445c073
Compare
charlag
reviewed
May 2, 2024
buildSrc/updateLibs.js
Outdated
| // different from the version in our package.json (the git url), we need to make sure that | ||
| // the installed version is in sync with the version given in package.json before we write it to | ||
| // vendored-versions.json | ||
| await $`npm i` |
There was a problem hiding this comment.
I wouldn't add npm i here, that would catch me off-guard. We should take whatever is already there imo
charlag
reviewed
May 2, 2024
buildSrc/updateLibs.js
Outdated
| .map((d) => (typeof d === "string" ? d : d.src)) | ||
| .map(path.normalize) | ||
| .map((srcPath) => srcPath.split(path.sep)[2]) | ||
| const versions = JSON.parse(fs.readFileSync(path.join(__dirname, "..", "package.json"), "utf-8")).dependencies |
There was a problem hiding this comment.
we do read versions from package-json multiple times but I am wondering if we should even take the resolved versions with npm list or such (would also make it more reliable if we remove npm i here)
we have a two-stage approach to vendoring libraries: * update the packages' version in package.json * run node buildSrc/updateLibs.js using this check in the test github workflow prevents that commits that contain step 1 but not step 2 can be merged to master. close #6901
murilopereirame
force-pushed
the
prevent-wrong-vendoring
branch
from
40b934e
to
a3ef88b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have a two-stage approach to vendoring libraries:
using this check in the test github workflow prevents that commits that contain step 1 but not step 2 can be merged to master.