[ios] Wrap ContactStore.enumateContacts with ContactStoreError #6914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to improve debugging errors with predicates. Co-authored by: wrd <wrd@tutao.de>
paw-hub
force-pushed
the
enumerate-contacts-wrapper
branch
from
d40148b
to
c124865
Compare
charlag
reviewed
May 3, 2024
| @@ -150,6 +150,16 @@ class IosMobileContactsFacade: MobileContactsFacade { | |||
| } | |||
| } | |||
|
|
|||
| private func enumerateContactsInContactStore( | |||
There was a problem hiding this comment.
I would prefer extension for ContactStore with something like enumerateContactsCatching but that's just a nitpick
wec43
added
the
state:tested-with-comments
|
Sometimes there is a significant delay between I delete a contact on iOS and the contact disappear on the same device, even the deletion was synced to desktop immediately (before it disappeared on iOS). Not sure if it is intended. |
|
That's a bit interesting! No, it's definitely not intended, as this commit doesn't actually change any functionality. I wonder if the issue was introduced earlier but never caught? |
|
Probably, but I cannot reliably reproduce it. Maybe it is because some network connection problem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to improve debugging errors with predicates.
Test notes