extract keyCache from KeyLoaderFacade and UserFacade and handle user … #6925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedhub
added
the
model changes
charlag
reviewed
May 10, 2024
| * @param keyLoader a function to load and decrypt the group key if it is not cached | ||
| */ | ||
| getCurrentGroupKey(groupId: Id, keyLoader: () => Promise<VersionedKey>): Promise<VersionedKey> { | ||
| return getFromMap(this.currentGroupKeys, groupId, async () => { |
There was a problem hiding this comment.
if loader rejects you will have a cached rejected promise
charlag
reviewed
May 10, 2024
| const newCurrentGroupKeyCache = new Map<Id, Promise<VersionedKey>>() | ||
| for (const membership of user.memberships) { | ||
| const cachedGroupKey = this.currentGroupKeys.get(membership.group) | ||
| if (cachedGroupKey != null && Number(membership.groupKeyVersion) === (await cachedGroupKey).version) { |
There was a problem hiding this comment.
if any of the cachedGroupKey reject the whole thing will fail
charlag
reviewed
May 10, 2024
| facade.setAccessToken("hello.") | ||
| facade.setUser({} as User) | ||
| o(facade.isPartiallyLoggedIn()).equals(true) | ||
| o(facade.isFullyLoggedIn()).equals(false) | ||
| }) | ||
|
|
||
| o("updateUserGroupKey - successfull", function () { |
There was a problem hiding this comment.
if you have related tests it might be nice to put them in a spec()
charlag
reviewed
May 10, 2024
Comment on lines
+74
to
+75
| // @ts-ignore | ||
| o(cachedUserGroupKey.version).equals(0) |
There was a problem hiding this comment.
rather than completely ts-ignoreing the line I would suggest to just unwrap it
Suggested change
| // @ts-ignore | |
| o(cachedUserGroupKey.version).equals(0) | |
| o(cachedUserGroupKey!.version).equals(0) |
sarashub
force-pushed
the
key-cache-1795
branch
2 times, most recently
from
01ec221
to
1ec4628
Compare
…group key updates using a distribution key. tutadb#1795
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…group key updates using a distribution key.
tutadb#1795