Handle PTS rollovers #131
Merged
Handle PTS rollovers #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was not emitting payloads with PTS values after the first, because the mocked value was only returning once.
MPEG-TS times are in terms of 1/90000th of a second, and it seems that value is written in terms of the full fraction, not just the denominator. We were storing the "90000" and dividing by it. This change should bring things in line with what I understand to be the more explicit way of referencing basetime.
MPEG-TS stores packet positions using 33 bits, which means that for long running streams the position will rollover approximately every 26.5 hours. TV Kitchen appliances need to be able to ingest videos and streams of any length, which means when rollovers occur the appliance needs to properly update the origin times to account for the rollover. Issue #130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for PTS rollovers, which occur around every 26.5 hours (every
2^33 / 90seconds).Ingestion appliances that extend the
AbstractVideoIngestionApplianceshould see this support without any needed changes.Related Issues
Resolves #130