Skip to content

Commit

Permalink
Readd isDisabled check
Browse files Browse the repository at this point in the history
Sorry @GeoSot.. Figured my proposal is breaking our spec and it would be still possible to trigger show via jQuery. Maybe it's better to leave it there even if it's somewhat redundant..
  • Loading branch information
alpadev authored and GeoSot committed Apr 19, 2021
1 parent c5b8c79 commit 0b144cb
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion js/src/tab.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ class Tab extends BaseComponent {
show() {
if ((this._element.parentNode &&
this._element.parentNode.nodeType === Node.ELEMENT_NODE &&
this._element.classList.contains(CLASS_NAME_ACTIVE))) {
this._element.classList.contains(CLASS_NAME_ACTIVE)) ||
isDisabled(this._element)) {
return
}

Expand Down

0 comments on commit 0b144cb

Please sign in to comment.