Skip to content

Commit

Permalink
drop the css var for a Sass css
Browse files Browse the repository at this point in the history
  • Loading branch information
mdo authored and XhmikosR committed Jan 19, 2021
1 parent 1544125 commit 2b6aa06
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion scss/_navbar.scss
Expand Up @@ -140,7 +140,7 @@
}

.navbar-nav-scroll {
max-height: var(--bs-scroll-height, 75vh);
max-height: $navbar-nav-scroll-max-height;
overflow-y: auto;
}

Expand Down
2 changes: 2 additions & 0 deletions scss/_variables.scss
Expand Up @@ -731,6 +731,8 @@ $navbar-toggler-padding-x: .75rem !default;
$navbar-toggler-font-size: $font-size-lg !default;
$navbar-toggler-border-radius: $btn-border-radius !default;

$navbar-nav-scroll-max-height: 75vh !default;

$navbar-dark-color: rgba($white, .5) !default;
$navbar-dark-hover-color: rgba($white, .75) !default;
$navbar-dark-active-color: $white !default;
Expand Down
6 changes: 3 additions & 3 deletions site/content/docs/4.5/components/navbar.md
Expand Up @@ -440,11 +440,11 @@ Also note that **`.sticky-top` uses `position: sticky`, which [isn't fully suppo

## Scrolling

Add `.navbar-nav-scroll` to a `.navbar-collapse` (or other navbar sub-component) to enable vertical scrolling within the toggleable contents of a collapsed navbar. By default, scrolling kicks in at `75vh` (or 75% of the viewport height), but you can override that with the local CSS custom property `--bs-navbar-height` or custom styles. At larger viewports when the navbar is expanded, content will appear as it does in a default navbar.
Add `.navbar-nav-scroll` to a `.navbar-collapse` (or other navbar sub-component) to enable vertical scrolling within the toggleable contents of a collapsed navbar. By default, scrolling kicks in at `75vh` (or 75% of the viewport height), but you can override that with inline or custom styles. At larger viewports when the navbar is expanded, content will appear as it does in a default navbar.

Please note that this behavior comes with a potential drawback of `overflow`—when setting `overflow-y: auto` (required to scroll the content here), `overflow-x` is the equivalent of `auto`, which will crop some horizontal content.

Here's an example navbar using `.navbar-nav-scroll` with `style="--bs-scroll-height: 100px;"`, with some extra margin utilities for optimum spacing.
Here's an example navbar using `.navbar-nav-scroll` with `style="max-height: 100px;"`, with some extra margin utilities for optimum spacing.

{{< example >}}
<nav class="navbar navbar-expand-lg navbar-light bg-light">
Expand All @@ -453,7 +453,7 @@ Here's an example navbar using `.navbar-nav-scroll` with `style="--bs-scroll-hei
<span class="navbar-toggler-icon"></span>
</button>
<div class="collapse navbar-collapse" id="navbarScroll">
<ul class="navbar-nav mr-auto my-2 my-lg-0 navbar-nav-scroll" style="--bs-scroll-height: 100px;">
<ul class="navbar-nav mr-auto my-2 my-lg-0 navbar-nav-scroll" style="max-height: 100px;">
<li class="nav-item active">
<a class="nav-link" href="#">Home <span class="sr-only">(current)</span></a>
</li>
Expand Down

0 comments on commit 2b6aa06

Please sign in to comment.