Skip to content

Commit

Permalink
Carousel: rename private property
Browse files Browse the repository at this point in the history
  • Loading branch information
GeoSot authored and XhmikosR committed Mar 10, 2022
1 parent ec0e1c2 commit 3673933
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions js/src/carousel.js
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ class Carousel extends BaseComponent {

this._interval = null
this._activeElement = null
this._isPaused = false
this._stayPaused = false
this._isSliding = false
this.touchTimeout = null
this._swipeHelper = null
Expand Down Expand Up @@ -139,7 +139,7 @@ class Carousel extends BaseComponent {

pause(event) {
if (!event) {
this._isPaused = true
this._stayPaused = true
}

if (SelectorEngine.findOne(SELECTOR_NEXT_PREV, this._element)) {
Expand All @@ -152,11 +152,11 @@ class Carousel extends BaseComponent {

cycle(event) {
if (!event) {
this._isPaused = false
this._stayPaused = false
}

this._clearInterval()
if (this._config.interval && !this._isPaused) {
if (this._config.interval && !this._stayPaused) {
this._updateInterval()

this._interval = setInterval(() => this.nextWhenVisible(), this._config.interval)
Expand Down
8 changes: 4 additions & 4 deletions js/tests/unit/carousel.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -891,7 +891,7 @@ describe('Carousel', () => {

expect(carousel.cycle).toHaveBeenCalledWith(true)
expect(carousel._clearInterval).toHaveBeenCalled()
expect(carousel._isPaused).toBeTrue()
expect(carousel._stayPaused).toBeTrue()
})

it('should not call cycle if nothing is in transition', () => {
Expand All @@ -917,7 +917,7 @@ describe('Carousel', () => {

expect(carousel.cycle).not.toHaveBeenCalled()
expect(carousel._clearInterval).toHaveBeenCalled()
expect(carousel._isPaused).toBeTrue()
expect(carousel._stayPaused).toBeTrue()
})

it('should not set is paused at true if an event is passed', () => {
Expand All @@ -942,7 +942,7 @@ describe('Carousel', () => {
carousel.pause(event)

expect(carousel._clearInterval).toHaveBeenCalled()
expect(carousel._isPaused).toBeFalse()
expect(carousel._stayPaused).toBeFalse()
})
})

Expand Down Expand Up @@ -988,7 +988,7 @@ describe('Carousel', () => {

spyOn(window, 'setInterval').and.callThrough()

carousel._isPaused = true
carousel._stayPaused = true
carousel.cycle(true)

expect(window.setInterval).not.toHaveBeenCalled()
Expand Down

0 comments on commit 3673933

Please sign in to comment.